[Windows] Use CRLF in the terminal prints. #92158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @van800 @MatthiasBae if you can test. |
kus04e4ek
reviewed
May 20, 2024
|
I would like to test it but Godot won't build the managed libraries after creating the Mono Glue and I am not quite experienced in C++ or building C++ so I was following the instructions in the docs which works fine until the mentioned error. 
Having this issue #80739 It does not find the GeneratedIncludes.props file |
|
I confirm the issue was solved. |
|
I can also confirm both prints and errors are fine with this. |
akien-mga
approved these changes
May 21, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
\nwith\r\nin the Windows terminal prints.Might fix #91603 (I was not able to reproduce it, but this is the only possible reason I can think of).